Payment events: one central payment_result row for every path (callback, reconcile, Bazaar, renewal, 100% code), discount_applied, no duplicate order_created; Bazaar token never stored

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-13 14:44:50 +03:30
parent 8d8665edf3
commit 44ad2eabf3
4 changed files with 50 additions and 5 deletions

View File

@@ -25,3 +25,40 @@ class PaymentEventTests(TestCase):
with self.assertLogs('payment.events', level='ERROR'):
events.record('x', user_id=1)
self.assertEqual(Order.objects.count(), 0)
class PaymentResultEventTests(TestCase):
def test_result_is_recorded_without_bazaar_token(self):
from payment.services import apply_order_payment_result
order, _ = create_order(user_id=7, amount=1000, provider='bazaar', bazaar_product_sku='10342')
apply_order_payment_result(order=order, gateway='bazaar', gateway_ref_id='SECRET-TOKEN',
new_status='paid', event='bazaar_verify')
row = PaymentEvent.objects.get(order_id=order.id, event='payment_result')
self.assertEqual(row.detail['new_status'], 'paid')
self.assertFalse(row.detail['ignored'])
self.assertNotIn('SECRET-TOKEN', str(row.detail))
def test_duplicate_result_is_recorded_as_ignored(self):
from payment.services import apply_order_payment_result
order, _ = create_order(user_id=7, amount=1000)
for _ in range(2):
apply_order_payment_result(order=order, gateway='zarinpal', gateway_ref_id='R1',
new_status='paid', event='zarinpal_callback')
flags = list(PaymentEvent.objects.filter(order_id=order.id, event='payment_result')
.order_by('id').values_list('detail__ignored', flat=True))
self.assertEqual(flags, [False, True])
def test_zarinpal_callback_records_arrival_and_result(self):
from payment.zarinpal import ZarinpalVerifyResult
order, _ = create_order(user_id=7, amount=1000)
Order.objects.filter(pk=order.pk).update(gateway_authority='A123')
with mock.patch('payment.zarinpal.verify_payment',
return_value=ZarinpalVerifyResult(is_valid=True, ref_id='999')):
self.client.get('/api/payment/zarinpal/callback', {'Authority': 'A123', 'Status': 'OK'})
got = list(PaymentEvent.objects.filter(order_id=order.id).order_by('id').values_list('event', flat=True))
self.assertEqual(got, ['order_created', 'callback_received', 'payment_result'])
def test_unknown_authority_is_recorded_without_order(self):
self.client.get('/api/payment/zarinpal/callback', {'Authority': 'NOPE', 'Status': 'OK'})
row = PaymentEvent.objects.get(event='callback_unknown_authority')
self.assertIsNone(row.order_id)